Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yaml #112

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update config.yaml #112

merged 1 commit into from
Oct 16, 2023

Conversation

simonmcnair
Copy link
Contributor

@simonmcnair simonmcnair commented Oct 12, 2023

according to this issue beetbox/beets#4838

the default of beets should be to copy, rather than move so that the user does not modify their original files unless they have a full understanding of how the application works.

This has generated bugs and issues for the beets project. Which is undesired

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

according to this issue beetbox/beets#4838

the default of beets should be to copy, rather than move so that the user does not modify their original files unless they have a full understanding of how the application works.

This has generated bugs and issues for the beets project. Which is undesired
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@thespad thespad self-assigned this Oct 12, 2023
@simonmcnair
Copy link
Contributor Author

also referencing beetbox/beets#4860

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/beets/1.6.0-pkg-72c3f736-dev-60d74c74c817db6caf0f0c081b74dbcc02f5adec-pr-112/index.html
https://ci-tests.linuxserver.io/lspipepr/beets/1.6.0-pkg-72c3f736-dev-60d74c74c817db6caf0f0c081b74dbcc02f5adec-pr-112/shellcheck-result.xml

Tag Passed
amd64-1.6.0-pkg-72c3f736-dev-60d74c74c817db6caf0f0c081b74dbcc02f5adec-pr-112
arm64v8-1.6.0-pkg-72c3f736-dev-60d74c74c817db6caf0f0c081b74dbcc02f5adec-pr-112

@thespad thespad merged commit 8ebce64 into linuxserver:master Oct 16, 2023
4 checks passed
@simonmcnair simonmcnair deleted the patch-1 branch November 20, 2023 16:15
@RollingStar
Copy link

Thank you! We're open to more communication and collaboration between our two organizations in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants